99.6% hull.py test coverage - #2096
Merged
Merged
Conversation
added 2 commits
September 14, 2026 12:28
They were computed as if every arc were centred at the origin, so select_lowest_arc compared meaningless points for partial arcs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
+ Coverage 95.76% 95.80% +0.04%
==========================================
Files 30 30
Lines 9584 9589 +5
Branches 1437 1439 +2
==========================================
+ Hits 9178 9187 +9
+ Misses 250 247 -3
+ Partials 156 155 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I hope to polish hull in a few follow-up PRs and cover the known issues:
Convex hull is a beautiful and useful feature. It deserves to graduate from experimental. |
jmwright
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for the bits of hull.py nothing was hitting.
Two of them found real bugs along the way - a lone circle didn't work,
and one input hung forever - so there's a small fix in "find_hull" too.